Merged
Conversation
…escendantSlugsAndUris
[6.x] Element actions & exporters
…anager # Conflicts: # yii2-adapter/legacy/elements/NestedElementManager.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Ports the remainder of the Elements service.
Other public services that have been extracted before from Elements:
ElementCaches[6.x] ElementCaches #18647ElementActivity[6.x] Element activity #18653ElementRelations[6.x] Refactor Element functionality to traits #18368Operations
The
Elementsservice itself has been split up as well to be a public service that forwards to the followingOperationservices:ElementCanonicalChangesElementDeletionsElementDuplicatesElementEagerLoaderElementPlaceholdersElementRefsElementUrisElementWritesThese services are marked as
@internal- meaning they should only be used within theElementnamespace, theElementsservice in particular.There is also no Facade created for any of these services as they really are meant to only be called by the Elements service.
This split allows us to have classes that are maintainable and tests that are separated by the concerns while still having one general service to interact with them.
Authorization
All authorization methods have not been ported over. These are now handled directly by using Laravel's
Gateor$user->can()through the ElementPolicy.The legacy service registers a before callback that fires the legacy authorization events.